[PATCH] D28623: [XRay][Arm] Enable back XRay testing on Arm32

[Serge Rogatch via Phabricator via llvm-commits]

rSerge added a comment.

@rengolin , yes, please. This patch should be tested together with https://reviews.llvm.org/D28624 , because this patch only enables the tests and that one repairs XRay on Arm32.



================
Comment at: test/xray/lit.cfg:35
+  config.unsupported = True
+elif config.host_arch.find('64') == -1 and config.host_arch.find('arm') == -1:
   config.unsupported = True
----------------
rengolin wrote:
> rSerge wrote:
> > dberris wrote:
> > > I'm not too familiar with the arm triples, but don't we only support xray on arm7? Does that distinction matter?
> > AFAIK, build-bots are currently only armv7 . Furthermore, I understood that tests can only execute on architectures in `ALL_XRAY_SUPPORTED_ARCH` from llvm\projects\compiler-rt\cmake\config-ix.cmake , and this makes me question why 64-bitness is checked here again...
> FWIW, all bots are ARMv7 and ARMv8. But that can break if someone is running the tests on, for example, a Raspberry Pi 1.
Oh, I meant "at least armv7". Armv8 should be ok. Armv6 is not fully supported by XRay (because movw and movt are written to the code at runtime).


https://reviews.llvm.org/D28623