[PATCH] D27243: Initial work on the XRay Graph tool.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 19:01:12 PST 2017


dberris added inline comments.


================
Comment at: test/tools/llvm-xray/X86/graph-simple-case.yaml:34-35
+#EMPTY:   digraph xray {
+#EMPTY:   F0 -> F1 [label="1"];
+#EMPTY:   F1 [label="@(1)"];
+#EMPTY:   }
----------------
varno wrote:
> dberris wrote:
> > Did you need to write "DAG" here somewhere too?
> I don't need DAG here as there is only one edge in this graph.
So as written, this will mean that if these lines are not arranged in exactly this order, the test will pass. If you meant to preserve order of the output lines being checked, you pick either `-DAG:` or `-NEXT:`.

This means, instead of:

```
#EMPTY:
#EMPTY:
#EMPTY:
```

It ought to be:

```
#EMPTY:
#EMPTY-NEXT:
#EMPTY-NEXT:
#EMPTY-NEXT:
```

to preserve the order of lines and matching.


https://reviews.llvm.org/D27243





More information about the llvm-commits mailing list