[PATCH] D28585: [RegisterCoalescing] Remove partial redundent copy

[Wei Mi via llvm-commits]

Thanks for taking a look.

On Thu, Jan 12, 2017 at 2:50 PM, Quentin Colombet via Phabricator <
reviews at reviews.llvm.org> wrote:

> qcolombet added a comment.
>
> Hi Wei,
>
> Could you write a .mir test instead of a .ll one?
> You should be able to get your input with `llc -stop-before=regalloc` or
> something like that.
>

Ok, I will add the .mir test.


>
> In the assumption I would add that because of:
>
> > we require that BB1 has only one successor so we always move a copy to a
> colder place.
>
> and
>
> > No B is referenced from the start of BB2 to B = A.
>
> We know that B is not defined at the end of BB1, which is otherwise a
> requirement.
>

That is true. Will add that in the comments.

Thanks,
Wei.


>
> I'll have a look at the patch later, unless Matthias beats me at it.
>
> Cheers,
> -Quentin
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D28585
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170112/0a945e76/attachment.html>