[PATCH] D28527: Check for register clobbers when merging a vreg live range with a reserved physreg in RegisterCoalescer.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 14:40:35 PST 2017


qcolombet added inline comments.


================
Comment at: test/CodeGen/AArch64/regcoal-physreg.mir:77
+
+    ; Need a def of x18 so that it's not deduced as "constant".
+    %x18 = COPY %xzr
----------------
That sounds like a bug to me.
I would have expected the constant attribute to be decided by the target, i.e., not something that depends on the presence of a definition.

Could you investigate please?


https://reviews.llvm.org/D28527





More information about the llvm-commits mailing list