[PATCH] D28075: MergeFunctions: Preserve debug info in thunks, under option -mergefunc-preserve-debug-info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Added some more stylistic changes.

Do you have any plans for surfacing this in clang?



================
Comment at: lib/Transforms/IPO/MergeFunctions.cpp:632
+
+// Replace G with a simple tail call to bitcast(F). Also (unless
+// MergeFunctionsPDI holds) replace direct uses of G with bitcast(F),
----------------
http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments


> Don’t duplicate the documentation comment in the header file and in the implementation file. Put the documentation comments for public APIs into the header file. Documentation comments for private APIs can go to the implementation file. In any case, implementation files can include additional comments (not necessarily in Doxygen markup) to explain implementation details as needed.



================
Comment at: lib/Transforms/IPO/MergeFunctions.cpp:695
+    DISubprogram *DIS = G->getSubprogram();
+    if (DIS != nullptr) {
+      DebugLoc CIDbgLoc = DebugLoc::get(DIS->getScopeLine(), 0, DIS);
----------------
if (DIS)


https://reviews.llvm.org/D28075