[PATCH] D28468: [X86] Fix for bugzilla 31576 - add support for "data32" instruction prefix

[Nirav Dave via Phabricator via llvm-commits]

niravd added a comment.

Sorry I think I was being overly terse and unclear.

For the disassembler, I'd like to make sure we generate the correct output text for 16-bit mode emitted data prefixes.

That is, we should have an explicit test to check that:
 echo ".byte 0x66" | as -32 -o /tmp/a.o
 llvm-objdump -triple i386-unknown-unknown-code16 -d /tmp/a.o

should give us "data32" not "data16"

For the other tests, I was looking for tests that check for errors we use data16/32 in an invalid mode or in a redundant way. So for 32-bit "data32 lgdt 0" should emit an error (redundant) and data32 should not be valid in 64-bit mode.


Repository:
  rL LLVM

https://reviews.llvm.org/D28468