[PATCH] D28291: [ARM] Create SubtargetFeatures from build attributes

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: test/tools/llvm-objdump/ARM/v7a-subfeature.s:1
+@ RUN: llvm-mc < %s -triple armv7a -mattr=+vfp3,+neon,+fp16,+hwdiv-arm -filetype=obj | llvm-objdump -triple=arm -d - | FileCheck %s
+
----------------
rengolin wrote:
> If you pass the `-mattr`, it doesn't need to read the `.eabi_attributes`, so what does this test really test?
As far as I can tell, the mattr is used by mc to detect valid instructions, but it is not used to encode the build attributes. So they're needed in the test so the attributes are encoded for objdump to read.


https://reviews.llvm.org/D28291