[PATCH] D28585: [RegisterCoalescing] Remove partial redundent copy

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 23:33:00 PST 2017


grandinj added inline comments.


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:194
+    /// We found a copy which can be moved to its less frequent predecessor.
+    bool removePartialRedundency(const CoalescerPair &CP, MachineInstr *CopyMI);
+
----------------
removePartialRedundency->removePartialRedundancy


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:870
+/// predecessor of BB2, and if B is not redefined on the way from A = B
+/// in BB2 to B = A in BB2, B = A in BB2 is partially redundent if the
+/// execution goes through the path from BB0 to BB2. We may move B = A
----------------
redundent ->redundant 


================
Comment at: test/CodeGen/X86/pre-coalesce.ll:3
+;
+; The test is to check no redundent mov as follows will be generated in %while.body loop.
+;  .LBB0_2:
----------------
redundent ->redundant 


Repository:
  rL LLVM

https://reviews.llvm.org/D28585





More information about the llvm-commits mailing list