[PATCH] D28584: Add is{Hot|Cold}CallSite and an unit test to ProfileSummaryInfo

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:140
+  auto *TI = B->getTerminator();
+  if (isa<ReturnInst>(TI))
+    return false;
----------------
is this a separate fix?


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:163
+    return isHotCount(TotalCount);
+  return BFI && isHotBB(CallInst->getParent(), BFI);
+}
----------------
should the order of check swapped? BFI check first and then meta data ?


https://reviews.llvm.org/D28584