[PATCH] D28107: [ELF] - Do not create huge garbage files on section offset overflow.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 15:12:26 PST 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar added a comment.
>
> In https://reviews.llvm.org/D28107#630909, @davide wrote:
>
>> This needs a testcase.
>
>
> Should it check that we do not create temporarily file ? Seems there is  no clean way to check this,
> we do not know its exact name from test.

I would still include the testcase where it was creating the large
temporary. Even if there is nothing to CHECK, it is still useful
documentation.

Cheers,
Rafael


More information about the llvm-commits mailing list