[PATCH] D28544: Remove all DWARFDie::getAttributeAsXXX() calls that returned default values and use new llvm::OptionalDefault template instead.

[Greg Clayton via llvm-commits]

Yep, I abandoned this an already have a new patch that switches over to use getValueOr.


> On Jan 10, 2017, at 9:22 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> On closer inspection it looks like llvm::Optional might already have what you need - a 'getValueOr' member function. Is that it?
> 
> On Tue, Jan 10, 2017 at 8:49 PM Greg Clayton via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> clayborg added a comment.
> 
> Do we want the case to be:
> 
>   llvm::ValueOr(...)
> 
> or
> 
>   llvm::value_or(...)
> 
> 
> https://reviews.llvm.org/D28544 <https://reviews.llvm.org/D28544>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170111/35ea8c20/attachment.html>