[PATCH] D28553: [ARM] CodeGen: New helpers for getting pred/CC operands. NFC

[Diana Picus via Phabricator via llvm-commits]

rovka created this revision.
rovka added reviewers: MatzeB, kristof.beyls.
rovka added a subscriber: llvm-commits.
Herald added subscribers: rengolin, aemerson.

Add helpers that create MachineOperands for predicates / condition code results
needed by instructions in the ARM backend. These are intended to replace the
AddDefaultPred/AddDefaultCC helpers.

Patches removing AddDefaultPred/CC follow. I can squash them before committing,
but I thought it would be easier to review this way.


https://reviews.llvm.org/D28553

Files:
  lib/Target/ARM/ARMBaseInstrInfo.h


Index: lib/Target/ARM/ARMBaseInstrInfo.h
===================================================================
--- lib/Target/ARM/ARMBaseInstrInfo.h
+++ lib/Target/ARM/ARMBaseInstrInfo.h
@@ -401,22 +401,41 @@
   bool isSwiftFastImmShift(const MachineInstr *MI) const;
 };
 
+/// Get the operands corresponding to the given \p Pred value. By default, the
+/// predicate register is assumed to be 0 (no register), but you can pass in a
+/// \p PredReg if that is not the case.
+static inline std::array<MachineOperand, 2> predOps(ARMCC::CondCodes Pred,
+                                                    unsigned PredReg = 0) {
+  return {{MachineOperand::CreateImm(static_cast<int64_t>(Pred)),
+           MachineOperand::CreateReg(PredReg, 0)}};
+}
+
+/// Get the operand corresponding to the conditional code result. By default,
+/// this is 0 (no register).
+static inline MachineOperand condCodeOp(unsigned CCReg = 0) {
+  return MachineOperand::CreateReg(CCReg, 0);
+}
+
+// FIXME: Remove when all uses are gone.
 static inline
 const MachineInstrBuilder &AddDefaultPred(const MachineInstrBuilder &MIB) {
   return MIB.addImm((int64_t)ARMCC::AL).addReg(0);
 }
 
+// FIXME: Remove when all uses are gone.
 static inline
 const MachineInstrBuilder &AddDefaultCC(const MachineInstrBuilder &MIB) {
   return MIB.addReg(0);
 }
 
+// FIXME: Replace with something that returns a MachineOperand directly.
 static inline
 const MachineInstrBuilder &AddDefaultT1CC(const MachineInstrBuilder &MIB,
                                           bool isDead = false) {
   return MIB.addReg(ARM::CPSR, getDefRegState(true) | getDeadRegState(isDead));
 }
 
+// FIXME: Replace with something that returns a MachineOperand directly.
 static inline
 const MachineInstrBuilder &AddNoT1CC(const MachineInstrBuilder &MIB) {
   return MIB.addReg(0);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28553.83953.patch
Type: text/x-patch
Size: 1830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170111/cecff85e/attachment.bin>