[PATCH] D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:5936
+// Patterns used for matching vcvtsi2s{s,d} intrinsic sequences from clang
+// which produce unnecsessary vmovs{s,d} instructions
+let Predicates = [HasAVX512] in {
----------------
unnecessary is spelled wrong


================
Comment at: lib/Target/X86/X86InstrSSE.td:1961
+} // Predicates = [UseAVX]
+let Predicates = [UseSSE2] in {
+def : Pat<(v4f32 (X86Movss
----------------
Can you add a blank like between the AVX block ending and the SSE block starting


================
Comment at: lib/Target/X86/X86InstrSSE.td:1984
+} // Predicates = [UseSSE2]
+let Predicates = [UseSSE1] in {
+def : Pat<(v4f32 (X86Movss
----------------
Blank line here too


https://reviews.llvm.org/D28455