[PATCH] D28452: [PM] Move the LoopPassManager to the transforms library.

[Justin Lebar via Phabricator via llvm-commits]

jlebar accepted this revision.
jlebar added a reviewer: jlebar.
jlebar added a comment.

Looks fine to me.



================
Comment at: include/llvm/Analysis/LoopAnalysisManager.h:18
+/// 2) Loops are *always* in LCSSA form.
+/// 3) A collection of Loop-specific analysis results are available:
+///    - LoopInfo
----------------
s/loop-specific//  (DominatorTree, SCEV, AAManager aren't loop-specific).


================
Comment at: include/llvm/Analysis/LoopAnalysisManager.h:50
+/// The adaptor from a function pass to a loop pass directly computes
+/// a standard set of analyses that are especially useful to loop passes and
+/// makes them available in the API. Loop passes are also expected to update
----------------
s/standard//


================
Comment at: include/llvm/Analysis/LoopAnalysisManager.h:52
+/// makes them available in the API. Loop passes are also expected to update
+/// all of these so that they remain correct across the entire loop pipeline.
+struct LoopStandardAnalysisResults {
----------------
Suggest

> The adaptor from a function pass to a loop pass computes these analyses and makes them available to the loop passes "for free".  Each loop pass is expected expected to update these analyses if necessary to ensure they're valid after it runs.


================
Comment at: include/llvm/Analysis/LoopAnalysisManager.h:67
+
+extern template class AnalysisManager<Loop, LoopStandardAnalysisResults &>;
+/// \brief The loop analysis manager.
----------------
nit, newline after?


https://reviews.llvm.org/D28452