[llvm] r291587 - [ARM] Remove rbit intrinsics and autoupgrade to generic bitreverse.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 11:23:52 PST 2017


Author: mcrosier
Date: Tue Jan 10 13:23:51 2017
New Revision: 291587

URL: http://llvm.org/viewvc/llvm-project?rev=291587&view=rev
Log:
[ARM] Remove rbit intrinsics and autoupgrade to generic bitreverse.

Testing already covered by CodeGen/ARM/rbit.ll

Modified:
    llvm/trunk/include/llvm/IR/IntrinsicsARM.td
    llvm/trunk/lib/IR/AutoUpgrade.cpp
    llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp

Modified: llvm/trunk/include/llvm/IR/IntrinsicsARM.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/IntrinsicsARM.td?rev=291587&r1=291586&r2=291587&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/IntrinsicsARM.td (original)
+++ llvm/trunk/include/llvm/IR/IntrinsicsARM.td Tue Jan 10 13:23:51 2017
@@ -156,11 +156,6 @@ def int_arm_hint : Intrinsic<[], [llvm_i
 def int_arm_dbg : Intrinsic<[], [llvm_i32_ty]>;
 
 //===----------------------------------------------------------------------===//
-// RBIT
-
-def int_arm_rbit : Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoMem]>;
-
-//===----------------------------------------------------------------------===//
 // UND (reserved undefined sequence)
 
 def int_arm_undefined : Intrinsic<[], [llvm_i32_ty]>;

Modified: llvm/trunk/lib/IR/AutoUpgrade.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/AutoUpgrade.cpp?rev=291587&r1=291586&r2=291587&view=diff
==============================================================================
--- llvm/trunk/lib/IR/AutoUpgrade.cpp (original)
+++ llvm/trunk/lib/IR/AutoUpgrade.cpp Tue Jan 10 13:23:51 2017
@@ -77,7 +77,7 @@ static bool UpgradeIntrinsicFunction1(Fu
   switch (Name[0]) {
   default: break;
   case 'a': {
-    if (Name.startswith("aarch64.rbit")) {
+    if (Name.startswith("arm.rbit") || Name.startswith("aarch64.rbit")) {
       NewFn = Intrinsic::getDeclaration(F->getParent(), Intrinsic::bitreverse,
                                         F->arg_begin()->getType());
       return true;

Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=291587&r1=291586&r2=291587&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Tue Jan 10 13:23:51 2017
@@ -3305,11 +3305,6 @@ ARMTargetLowering::LowerINTRINSIC_WO_CHA
   SDLoc dl(Op);
   switch (IntNo) {
   default: return SDValue();    // Don't custom lower most intrinsics.
-  case Intrinsic::arm_rbit: {
-    assert(Op.getOperand(1).getValueType() == MVT::i32 &&
-           "RBIT intrinsic must have i32 type!");
-    return DAG.getNode(ISD::BITREVERSE, dl, MVT::i32, Op.getOperand(1));
-  }
   case Intrinsic::thread_pointer: {
     EVT PtrVT = getPointerTy(DAG.getDataLayout());
     return DAG.getNode(ARMISD::THREAD_POINTER, dl, PtrVT);




More information about the llvm-commits mailing list