[PATCH] D28502: [compiler-rt] [Interception] Properly check for export table's size before referring to its elements.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 09:59:34 PST 2017


mpividori added a comment.

Ok. Some questions about the implementation of tests:

- I couldn't find any information about the files: `lit.common.cfg` . Are the same than `lib.cfg`? should I use "--config-prefix=lit.common"? I see some directories include "lit.cfg" and other include "lit.common.cfg". The documentation doesn't mention "lit.common" files.
- How should I run compiler-rt tests? After reading lit's documentation, I suppose it should work if I run:  " python llvm-lit.py  path-to-test-folder " But it always fails.

For example, running:  "python bin/llvm-lit.py  ../llvm/projects/compiler-rt/test" , I get:

  llvm-lit.py: ...llvm\utils\lit\lit\discovery.py:113: warning: unable to find test suite for '../llvm/projects/compiler-rt/test'
  llvm-lit.py: ...llvm\utils\lit\lit\discovery.py:224: warning: input '../llvm/projects/compiler-rt/test' contained no tests

I would appreciate your comments, I think lit's documentation is outdated.
Thanks,


https://reviews.llvm.org/D28502





More information about the llvm-commits mailing list