[PATCH] D28515: [Support] - Introduce zlib::toString(zlib::Status)

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 08:25:55 PST 2017


davide added a comment.

Can you add (unit)tests for this?



================
Comment at: lib/Support/Compression.cpp:94-95
+    return "";
+  case zlib::StatusUnsupported:
+    return "zlib is unavailable";
+  case zlib::StatusOutOfMemory:
----------------
`isAvailable()` returns always true, so, how can this be ever hit?


https://reviews.llvm.org/D28515





More information about the llvm-commits mailing list