[PATCH] D28234: Support for custom install dirs in CMake build

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 01:43:16 PST 2017


mgorny added inline comments.


================
Comment at: CMakeLists.txt:299
+    CACHE STRING "Define suffix of library directory name (32/64)" )
+set(CMAKE_INSTALL_BINDIR bin
+    CACHE STRING "Path for binary directory relative to CMAKE_INSTALL_PREFIX (defaults to 'bin')" )
----------------
beanz wrote:
> In keeping with our conventions these variables probably should start with `LLVM` instead of `CMAKE`.
And anyway, why were you reinventing GNUInstallDirs? If we want the CMAKE* vars, I don't see a reason not to use the module completely. 


Repository:
  rL LLVM

https://reviews.llvm.org/D28234





More information about the llvm-commits mailing list