[PATCH] D28270: Remove a unnecessary hasLoopInvariantOperands check in loop sink.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 15:45:44 PST 2017


sanjoy added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/Scalar/LoopSink.cpp:286
     Instruction *I = &*II++;
-    if (!L.hasLoopInvariantOperands(I) ||
-        !canSinkOrHoistInst(*I, &AA, &DT, &L, &CurAST, nullptr))
----------------
Did you consider asserting on `hasLoopInvariantOperands` instead?  That kind of checking tends to make things easier to debug.


Repository:
  rL LLVM

https://reviews.llvm.org/D28270





More information about the llvm-commits mailing list