[PATCH] D28482: [loop-unroll] Properly populate LoopInfo for loops cloned in LoopUnrollRuntime.

Michael Zolotukhin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 15:20:49 PST 2017


mzolotukhin accepted this revision.
mzolotukhin added a comment.
This revision is now accepted and ready to land.

Thanks for fixing it! The patch looks good to me, but I'd suggest committing it in two separate pieces: 1) factoring out `addClonedBlockToLoopInfo` (that should be NFC), 2) fixing `CloneLoopBlocks` in `LoopUnrollRuntime.cpp`. Also, I recommend to drop unnecessary whitespace changes.

Michael


https://reviews.llvm.org/D28482





More information about the llvm-commits mailing list