[PATCH] D27808: [globalisel] Initialize RegisterBanks with static data. Part 2 of 2.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 14:27:05 PST 2017


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Daniel,

LGTM but squash it with the other part of this patch.

Cheers,
-Quentin



================
Comment at: include/llvm/CodeGen/GlobalISel/RegisterBankInfo.h:400
+  void setRegBankData(unsigned ID, const char *Name, unsigned Size,
+                      const uint32_t *CoveredClasses);
 
----------------
Rename in createRegisterBank and merge the comment form the different methods.


================
Comment at: lib/Target/AArch64/AArch64GenRegisterBankInfo.def:21
 
+const uint32_t GPRCoverageData[] = {
+    // Classes 0-31
----------------
I would squash this part with the tablgen patch.


https://reviews.llvm.org/D27808





More information about the llvm-commits mailing list