[PATCH] D28430: ELF: Implement support for .gnu.linkonce.t.*.

[Peter Collingbourne via llvm-commits]

On Mon, Jan 9, 2017 at 5:23 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Peter Collingbourne <peter at pcc.me.uk> writes:
>
> > Agreed that we should fix, but I suppose that even if we fix it now we'll
> > still encounter bad objects in the wild for a few years.
>
> Yes, but only on glibc i386.
>
> > One observation we made was that the linkonce was conflicting with a real
> > comdat, so maybe a simpler thing we could do is to discard all linkonce
> > sections? (Away from computer, can't check if that works.)
>
> Yes, that would be better. We should also have a bug to remove the hack
> at some point. The problem is that linkonce is a really broken design,
> so we should push for comdats as much as we can.
>

Okay, I've updated the patch.

I was also about to send a fix for glibc to libc-alpha, but it looks like
Adhemerval Zanella already did it (
https://sourceware.org/ml/libc-alpha/2017-01/msg00145.html).
Thanks Adhemerval!

Also filed PR31586 to track the removal.

Thanks,
-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170109/9861e132/attachment.html>