[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

[Daniel Berlin via llvm-commits]

On Mon, Jan 9, 2017 at 12:56 AM, Manuel Klimek <klimek at google.com> wrote:

> On Sat, Dec 31, 2016 at 12:49 AM Daniel Berlin <dberlin at dberlin.org>
> wrote:
>
>> On Fri, Dec 30, 2016 at 3:36 PM, Mehdi Amini <mehdi.amini at apple.com>
>> wrote:
>>
>>
>> On Dec 30, 2016, at 3:26 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
>>
>>
>> PS: consider sending replies in phabricator, because email replies
>> sometimes doesn't appear there (like this one)
>>
>>
>> I'm strongly against that, in the sense that phabricator needs to
>> integrate with existing workflows.  I do real reviews in phab, but just
>> overall commenting, don't have time or energy to click when i'm reading
>> email :)
>>
>> If email to phabricator is not currently working, we should fix that.
>> (I believe it is *supposed to be working*)
>>
>>
>> Inline answer in emails never worked in Phab. AFAIK.
>>
>>
>>
>> Sigh.
>>
>>
>> It use to be that top answers were included as comment. But even that was
>> not in Phab upstream but in our instance only (IIUC), so it can easily have
>> been lost with any update.
>>
>> That seems super annoying.
>>
>> Even bugzilla can get this right :(
>>
>
> Generally, only top-posting has worked in replies to update phab. Parsing
> in-line replies across different email clients is a PITA, unfortunately, so
> unless we find somebody who'd have fun hacking that up, it's unlikely to
> happen.
>

I have one that will work for a very large set of cases, but not inline
replies (ie it handles top and bottom)
It's python though, i can make it parse whatever and spit out the reply
part.

For example, for your email, it comes up with:
>>> print
email_reply_parser.EmailReplyParser.parse_reply(a.get_payload()[0].as_string())

"Content-Type: text/plain; charset=UTF-8
Generally, only top-posting has worked in replies to update phab. Parsing
in-line replies across different email clients is a PITA, unfortunately, so
unless we find somebody who'd have fun hacking that up, it's unlikely to
happen.

Currently, incoming email parsing is also completely broken, because the
https switch invalidated our sendgrid config, and sendgrid now wants us to
jump through hoops to update the info...
"

(note the email is mime, has attached content, blah blah blah)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170109/8ec2705a/attachment.html>