[PATCH] D28459: Make processing @llvm.assume more efficient - Add affected values to the assumption cache

[Piotr Padlewski via Phabricator via llvm-commits]

Prazek added a comment.

Are you planning to put it in 4.0 release? Sorry for only syntactic comments, didn't have time to go through code in details.



================
Comment at: include/llvm/Analysis/AssumptionCache.h:55
+  public:
+    typedef DenseMapInfo<Value *> DMI;
+
----------------
using


================
Comment at: include/llvm/Analysis/AssumptionCache.h:57
+
+    AffectedValueCallbackVH(Value *V, AssumptionCache *AC = nullptr)
+        : CallbackVH(V), AC(AC) {}
----------------
explicit?


================
Comment at: include/llvm/Analysis/AssumptionCache.h:65
+  /// information to the relevant set of assumptions.
+  typedef DenseMap<AffectedValueCallbackVH, SmallVector<WeakVH, 1>,
+                   AffectedValueCallbackVH::DMI> AffectedValuesMap;
----------------
using?


https://reviews.llvm.org/D28459