[PATCH] D28369: Refactor inline threshold update code.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 09:59:14 PST 2017


chandlerc added a comment.

This LGTM, but please make sure you update the changed escription to explain exactly what all is changing here. For example with the cold vs. minsize, I think it's safe, and we can't even really usefully test it as in tree this never happens. But you may need to explain to people that if they *do* have a crazy minsize vs. cold threshold, they may need to fix them now.

Thanks for the refactoring!


https://reviews.llvm.org/D28369





More information about the llvm-commits mailing list