[PATCH] D24510: [mips] Correct c.cond.fmt instruction definition.

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 09:20:04 PST 2017


sdardis updated this revision to Diff 83638.
sdardis marked an inline comment as done.
sdardis added a comment.

Fix undiscovered bug in the handling of FCMP & friends. Internally generated c.cond.fmt were using the low bits of the register number to also select the fcc register.

Cleaned up error messages.

Addressed comments from reviewer.


https://reviews.llvm.org/D24510

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/MCTargetDesc/MipsBaseInfo.h
  lib/Target/Mips/MicroMipsInstrFPU.td
  lib/Target/Mips/MicroMipsInstrFormats.td
  lib/Target/Mips/MipsFastISel.cpp
  lib/Target/Mips/MipsInstrFPU.td
  lib/Target/Mips/MipsInstrFormats.td
  test/MC/Disassembler/Mips/mips4/valid-xfail-mips4.txt
  test/MC/Mips/micromips/valid.s
  test/MC/Mips/mips1/invalid-mips4-wrong-error.s
  test/MC/Mips/mips1/invalid-mips4.s
  test/MC/Mips/mips1/invalid-mips5-wrong-error.s
  test/MC/Mips/mips1/invalid-mips5.s
  test/MC/Mips/mips2/invalid-mips32.s
  test/MC/Mips/mips2/invalid-mips32r2.s
  test/MC/Mips/mips2/invalid-mips4-wrong-error.s
  test/MC/Mips/mips2/invalid-mips4.s
  test/MC/Mips/mips2/invalid-mips5.s
  test/MC/Mips/mips3/invalid-mips4-wrong-error.s
  test/MC/Mips/mips3/invalid-mips4.s
  test/MC/Mips/mips3/invalid-mips5-wrong-error.s
  test/MC/Mips/mips3/invalid-mips5.s
  test/MC/Mips/mips32/valid-xfail.s
  test/MC/Mips/mips32/valid.s
  test/MC/Mips/mips32r2/valid-xfail.s
  test/MC/Mips/mips32r2/valid.s
  test/MC/Mips/mips32r3/valid-xfail.s
  test/MC/Mips/mips32r3/valid.s
  test/MC/Mips/mips32r5/valid-xfail.s
  test/MC/Mips/mips32r5/valid.s
  test/MC/Mips/mips4/valid-xfail.s
  test/MC/Mips/mips4/valid.s
  test/MC/Mips/mips5/valid-xfail.s
  test/MC/Mips/mips5/valid.s
  test/MC/Mips/mips64/valid-xfail.s
  test/MC/Mips/mips64/valid.s
  test/MC/Mips/mips64r2/valid-xfail.s
  test/MC/Mips/mips64r2/valid.s
  test/MC/Mips/mips64r3/valid-xfail.s
  test/MC/Mips/mips64r3/valid.s
  test/MC/Mips/mips64r5/valid-xfail.s
  test/MC/Mips/mips64r5/valid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24510.83638.patch
Type: text/x-patch
Size: 160136 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170109/14fd85f6/attachment-0001.bin>


More information about the llvm-commits mailing list