[PATCH] D28196: [X86] Tune bypassing of slow division for Intel CPUs

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D28196#639731, @n.bozhenov wrote:

> Hi Sanjay,
>
> In https://reviews.llvm.org/D28196#633259, @spatel wrote:
>
> > Can you update the CHECK lines in both of the test files using utils/update_llc_test_checks.py as a preliminary step ahead of this patch (no review required)? This has 3 benefits:
> >
> > 1. We get tighter checks.
> > 2. It's easier to update the test files for this and future transforms.
> > 3. It's easier to see the diffs induced by this patch.
>
>
> Not sure what you mean exactly. Please take a look at https://reviews.llvm.org/D28469. Is it what you mean? Is any additional postprocessing needed after running update_llc_test_checks.py?


Yes, that's what I was suggesting in general. Once you have generated the baseline checks with the script, it is very simple to apply your code patch and then run the script again to update the checks.

Usually for small tests like this, we prefer to leave the auto-generated checks as-is (no hand edits), but if you think there is a lot of unnecessary checking with the script, you can remove those lines. Similarly, if the script does not capture some useful info (like loaded constant values), you can add those lines to the auto-generated checks.


https://reviews.llvm.org/D28196