[PATCH] D28430: ELF: Implement support for .gnu.linkonce.t.*.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 9 05:23:53 PST 2017
Peter Collingbourne <peter at pcc.me.uk> writes:
> Agreed that we should fix, but I suppose that even if we fix it now we'll
> still encounter bad objects in the wild for a few years.
Yes, but only on glibc i386.
> One observation we made was that the linkonce was conflicting with a real
> comdat, so maybe a simpler thing we could do is to discard all linkonce
> sections? (Away from computer, can't check if that works.)
Yes, that would be better. We should also have a bug to remove the hack
at some point. The problem is that linkonce is a really broken design,
so we should push for comdats as much as we can.
Cheers,
Rafael
More information about the llvm-commits
mailing list