[PATCH] D28092: [ELF] - Specify -section argument for objdump calls in testcases.

[George Rimar via Phabricator via llvm-commits]

grimar abandoned this revision.
grimar added a comment.

In https://reviews.llvm.org/D28092#631265, @davide wrote:

> As a side note, this makes slightly more annoying updating tests. If you rename a section, you need to modify two places, and if you're adding a section which you need to dump, then you need to change the linker invocation. Not the end of the world, but why?


We probably usually do not rename or add sections when updating tests. That happens sometimes, but more often case is updating checked values when test fails, in that case reducing of printed data can be useful. It is IMO a bit more convinent to see data of single section on output to find the difference with test than have data from many sections both used and unused in checks. I was sure we used -section=xxx in other tests because of that reason (to keep output minimized to help debugging testcases a bit). 
At least that was my motivation in other patches where I added -section=xxx intitially.

Now it is not clear for me why we have this parameter in other tests then. May be it worst to remove it then ?

Since you and Rui are not fond of this patch, I am abandoning this diff.


https://reviews.llvm.org/D28092