[PATCH] D28114: [StructurizeCfg] Update dominator info.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 8 19:33:10 PST 2017


dberlin added a comment.

I'm fairly confused.
Forward dominators should  not have multiple roots at once without multiple actual entry blocks (which i didn't think we supported).
Yet you seem to be creating such a thing.
That seems ... wrong.
What am i missing?

Post-dom can have multiple roots due to multiple exit blocks, but honestly, we kind of mess this up, and would likely be much better off having a single virtual root, and removing the support for multiple real roots
(which is what everyone else does)


https://reviews.llvm.org/D28114





More information about the llvm-commits mailing list