[PATCH] D23630: [PPC] Expand ISEL instruction into if-then-else sequence

[Tony Jiang via Phabricator via llvm-commits]

jtony added inline comments.


================
Comment at: lib/Target/PowerPC/PPCTargetMachine.cpp:415
 void PPCPassConfig::addPreEmitPass() {
+  addPass(createPPCExpandISELPass(), false);
+  
----------------
nemanjai wrote:
> kbarton wrote:
> > hfinkel wrote:
> > > Do you require the verifyAfter = false here? (I'm not sure why we have that for the others either). Can you test without it?
> > Did this get done? 
> > I agree it would be better to not use verifyAfter=false here unless it is needed for some reason. 
> I don't know the characteristics of the verification, but I assume that it takes some non-zero compile time and that it will run verification in all build modes.
> If this is the case, I am personally in favour of adding a call to `MachineFunction::verify()` at the end of `RunOnMachineFunction()` wrapped in an `#ifndef NDEBUG` so that we get the verification with asserts and in debug mode, but save the associated compile-time in release mode.
 verifyAfter=false is removed now, by default we will use verifyAfter=true, so the verification is done always.


https://reviews.llvm.org/D23630