[PATCH] D28384: Update update_test_checks to work properly with phi nodes and other fun things.

bryant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 7 10:41:16 PST 2017


bryant accepted this revision.
bryant added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.

Thank you for working on this.



================
Comment at: utils/update_test_checks.py:183
+  for i in xrange(len(lines)):
+    line = lines[i]
     # An IR variable named '%.' matches the FileCheck regex string.
----------------
for i, line in enumerate(lines):
    line = line.replace
    scrubbed_line = 
    lines[i] = IR_VALUE_RE.sub(..., scrubbed_line)


https://reviews.llvm.org/D28384





More information about the llvm-commits mailing list