[PATCH] D28203: Enable weak hooks on darwin

[Francis Ricci via Phabricator via llvm-commits]

fjricci added inline comments.


================
Comment at: cmake/Modules/SanitizerUtils.cmake:53
+  foreach(SYMBOL ${WEAK_SYMBOLS})
+    set(local_linkflags ${local_linkflags} -Wl,-U,${SYMBOL})
+  endforeach()
----------------
kubabrecka wrote:
> nit: add a comment saying that this is specific to Darwin/Mach-O
Will do before commit.


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:35
 
-#if (SANITIZER_LINUX || SANITIZER_WINDOWS) && !SANITIZER_GO
+#if (SANITIZER_LINUX || SANITIZER_MAC || SANITIZER_WINDOWS) && !SANITIZER_GO
 # define SANITIZER_SUPPORTS_WEAK_HOOKS 1
----------------
compnerd wrote:
> kubabrecka wrote:
> > What about FreeBSD?  Just curious.
> I believe that FreeBSD uses ELF, so it should be able to support weak linkage.  However, if its untested ...
I don't have any way to run this on FreeBSD, so I'll leave this for future work.


Repository:
  rL LLVM

https://reviews.llvm.org/D28203