[PATCH] D27938: [LICM] Report successful hoists/sinks

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 18:29:58 PST 2017


davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Scalar/LICM.cpp:220-224
 bool LoopInvariantCodeMotion::runOnLoop(Loop *L, AliasAnalysis *AA,
                                         LoopInfo *LI, DominatorTree *DT,
                                         TargetLibraryInfo *TLI,
-                                        ScalarEvolution *SE, bool DeleteAST) {
+                                        ScalarEvolution *SE,
+                                        OptimizationRemarkEmitter *ORE,
----------------
`runOnLoop` and friends now take 8 arguments. I think it's a bit too much. Not your fault but clearly a sign that LICM structure could use some love.


https://reviews.llvm.org/D27938





More information about the llvm-commits mailing list