[PATCH] D27962: Get function start line number from DWARF info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:442
 
-static bool getFunctionNameForAddress(DWARFCompileUnit *CU, uint64_t Address,
-                                      FunctionNameKind Kind,
-                                      std::string &FunctionName) {
-  if (Kind == FunctionNameKind::None)
-    return false;
+static uint32_t getStartLineFromDie(const DWARFDie &DIE, uint32_t FailValue) {
+  uint32_t StartLine =
----------------
We're trying to get rid of all DWARF APIs that use special failure values right now. Could this return an Optional<uint32_t> instead?


https://reviews.llvm.org/D27962