[PATCH] D28203: Enable weak hooks on darwin

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 13:46:20 PST 2017


compnerd added a comment.

Ish.  Most linkers can read the arguments from a file.  The GNU linker uses `@file` syntax as does link (Windows).    ld64 can read a set of files to link via `-file_list` but not all the arguments AFAIK.

COFF does not allow any undefined symbols anyways, and this patch addresses MachO.  On ELFish targets, `-z defs` will prevent undefined symbols even in DSOs, but I don't think that applies to `STB_WEAK` symbols.

FWIW, I think that getting the same behavior across the two is a bit beyond the scope of this change.


https://reviews.llvm.org/D28203





More information about the llvm-commits mailing list