[PATCH] D28384: Update update_test_checks to work properly with phi nodes and other fun things.

[bryant via Phabricator via llvm-commits]

bryant added a comment.

> Also, this requires we capture more of the group. You are just taking group(1), which is ... not right, because it will delete all the spacing, the parens, the commas, etc, because sub expects a replacement for the entire match.
> We then have to reconstitute a correct replacement by capturing all of the line.

Capture only that which needs to be replaced. Why do you need to capture the spacing, parens, commas, `INTERVENING_STUFF`? I think I'm missing something critically obvious.


https://reviews.llvm.org/D28384