[PATCH] D27792: IfConversion: Use reverse_iterator to simplify. NFC

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 01:02:59 PST 2017


fhahn added inline comments.


================
Comment at: lib/CodeGen/IfConversion.cpp:625
       break;
     FIB = skipDebugInstructionsForward(FIB, FIE);
+    if (FIB == FIE)
----------------
I think we could first execute both TIB = skipDebugInstructionsForward(TIB, TIE); and FIB = skipDebugInstructionsForward(FIB, FIE); and then break from a single if. You already do that at line 722.


https://reviews.llvm.org/D27792





More information about the llvm-commits mailing list