[PATCH] D27911: [LoopUnroll] Keep UP.Count when considering complete unroll

Evgeny Stupachenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 18:02:01 PST 2017


evstupac added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:785
   unsigned FullUnrollTripCount = ExactTripCount ? ExactTripCount : MaxTripCount;
-  UP.Count = FullUnrollTripCount;
+  UP.Count = UP.Count ? UP.Count : FullUnrollTripCount;
   if (FullUnrollTripCount && FullUnrollTripCount <= UP.FullUnrollMaxCount) {
----------------
Will it work if we put UP.Count change under FullUnrollTripCount condition?
If we leave the change as is it could happen that for full unroll UP.Count is less than MaxTripCount. Which is not ok.
Also could you please add context to the patch:
svn diff --diff-cmd=diff -x -U999999


Repository:
  rL LLVM

https://reviews.llvm.org/D27911





More information about the llvm-commits mailing list