[PATCH] D28272: ELF: Reserve space for copy relocations of read-only symbols in relro.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 17:43:29 PST 2017


On Thu, Jan 5, 2017 at 2:56 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:

>
>
> On Thu, Jan 5, 2017 at 2:55 PM, Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> Peter Collingbourne <peter at pcc.me.uk> writes:
>> >
>> > Yes, but we'd still need a page alignment at the start of the r/w
>> segment,
>> > no?
>>
>> True. It is still seems better to pay the extra page than to allocate
>> disk space for copy relocations.
>>
>
> Agreed.
>

I uploaded a new version of the patch to phab. Since this changes the
section ordering, it breaks the expected output of a large number of test
cases. I went through and updated all the test cases beginning with the
letter "a" and will do the rest once we're agreed on the code changes.

Thanks,
-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170105/5e547969/attachment.html>


More information about the llvm-commits mailing list