[PATCH] D28094: [ELF] - Implemented support for R_386_PC8/R_386_8 relocations.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 15:25:04 PST 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> Somewhat orthogonal to this patch, but I think we need to modify `X86TargetInfo::relocateOne` so that we explicitly list relocation types that we understand and error out other relocations.

I agree. It might be even better to change the various default: cases of
getRelExpr to call error, that way we get an early diagnostic and record
that an error was found.

Cheers,
Rafael


More information about the llvm-commits mailing list