[PATCH] D28359: [compiler-rt] Use common static library for sanitizer_common.

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a reviewer: chandlerc.
filcab added a comment.

This seems a bit the opposite of part of r159129 (I'm adding Chandler so it's on his radar).
The sanitizers which can be combined are combined by having a "main" one, which includes the RT library for the other one, aren't they?
As in:
ASan will include ASan-base, LSan, UBSan, SanitizerCommon
etc.

I'm not sure what this change will improve it. Like Kuba said, the clang driver is the one that knows about the sanitizers, and which runtimes are needed, and needs to only link ASan in the case where ASan and UBSan are requested. IIRC, this is the same on other platforms. It's that way on the PS4 too.

Thank you,

  Filipe


Repository:
  rL LLVM

https://reviews.llvm.org/D28359