[PATCH] D28359: [compiler-rt] Use common static library for sanitizer_common.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added inline comments.


================
Comment at: lib/stats/CMakeLists.txt:19
+    STATIC
+    ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH}
+    OS ${SANITIZER_COMMON_SUPPORTED_OS}
----------------
aizatsky wrote:
> mpividori wrote:
> > aizatsky wrote:
> > > This one doesn't have RTSanitizerCommon & RTSanitizerCommonLibc. Is this intended?
> > @aizatsky Yes, this is intended. I remove that from from sanitizer static libraries, and move that code to `san_common` static library.
> But SHARED version needs them (above)?
@aizatsky Yes, shared versions include all the necessary code. This changes are only for STATIC libraries.


Repository:
  rL LLVM

https://reviews.llvm.org/D28359