[PATCH] D28079: [GlobalISel] Add support for indirectbr

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-instructionselect.mir:1931
+# CHECK:   bb.0:
+# CHECK:    BR %0
+body:             |
----------------
I think we miss a check of %0 = COPY %x0


================
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll:133
+  %arrayidx = getelementptr inbounds [3 x i8*], [3 x i8*]* @indirectbr.L, i64 0, i64 %idxprom
+  %0 = load i8*, i8** %arrayidx, align 8
+  indirectbr i8* %0, [label %L1, label %L2]
----------------
Get rid of implicit naming please.


================
Comment at: test/CodeGen/X86/implicit-null-checks.mir:322
 # CHECK:  %rbx = MOV64rr %rdx
-# CHECK-NEXT:  %rdi = FAULTING_LOAD_OP %bb.3.is_null, 260, killed %rbx, killed %rdi, 1, _, 0, _, implicit-def dead %eflags :: (load 4 from %ir.x)
+# CHECK-NEXT:  %rdi = FAULTING_LOAD_OP %bb.3.is_null, {{[0-9]+}}, killed %rbx, killed %rdi, 1, _, 0, _, implicit-def dead %eflags :: (load 4 from %ir.x)
 
----------------
This is an unrelated change, right?


https://reviews.llvm.org/D28079