[PATCH] D27857: [PATCH][DWARF] Don't propagate or set debug locations for PRE loads and associated address calculations

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 14:56:28 PST 2017


wolfgangp added a comment.

In https://reviews.llvm.org/D27857#635847, @aprantl wrote:

> Is this a case where using new the merge debug location api would make sense because we are merging multiple loads into one, or are we just deleting it so line table doesn't jump back and forth? If yes, we should use it here, otherwise this looks fine.


No, we are effectively moving an instruction from its original place to a different BB, so there is nothing to merge. As you said, we are mostly concerned about line table jumping.


https://reviews.llvm.org/D27857





More information about the llvm-commits mailing list