[PATCH] D27867: AMDGPU: Add Assert[SZ]Ext during argument load creation

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 11:21:23 PST 2017


kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:728-732
+  else if (Signed) {
+    Val = DAG.getSExtOrTrunc(Val, SL, VT);
+  } else {
+    Val = DAG.getZExtOrTrunc(Val, SL, VT);
+  }
----------------
Drop braces for single line ifs?


================
Comment at: test/CodeGen/AMDGPU/min.ll:83-91
 ; SI: v_min_i32
 ; SI: v_min_i32
 ; SI: v_min_i32
 ; SI: v_min_i32
 
-; SI: s_endpgm
+; VI: v_min_i32
+; VI: v_min_i32
----------------
Merge and rename to GCN label?


https://reviews.llvm.org/D27867





More information about the llvm-commits mailing list