[PATCH] D28302: [PowerPC] Implement missing instructions.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 10:48:14 PST 2017


hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:1035
   case PPCISD::FCTIWZ:          return "PPCISD::FCTIWZ";
+  case PPCISD::FCTIDU:         return "PPCISD::FCTIDU";
+  case PPCISD::FCTIWU:         return "PPCISD::FCTIWU";
----------------
The spacing is off here (but unless you're adding code that uses these, save this for later).


================
Comment at: lib/Target/PowerPC/PPCISelLowering.h:51
       /// unsigned integers.
+      FCTIDU, FCTIWU,
+
----------------
Please add these only in a patch that uses them.


https://reviews.llvm.org/D28302





More information about the llvm-commits mailing list