[PATCH] D28261: Correct the parent testing to avoid the special case where a DIE has a depth of 1

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 09:57:03 PST 2017


I think I mentioned this in a previous code review - is the special case
for depth 1 worth keeping? I'd suggest removing it to simplify the code, I
doubt it makes a big difference.

- Dave

On Tue, Jan 3, 2017 at 4:21 PM Phabricator via Phabricator <
reviews at reviews.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL290918: Correct the parent testing to avoid the special
> case where a DIE has a depth of… (authored by gclayton).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D28261?vs=82967&id=82971#toc
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D28261
>
> Files:
>   llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170104/a82f3ae0/attachment.html>


More information about the llvm-commits mailing list