[PATCH] D27114: Preserve nonnull metadata on Loads through SROA & mem2reg.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: test/Transforms/SROA/preserve-nonnull.ll:1
+; RUN: opt < %s -sroa -instcombine -S | FileCheck %s
+;
----------------
I don't think you want to include -instcombine here and create a dependency on its canonicalization of the assume to metadata - especially since that may change based on the comments in this review and PR31518 ( https://llvm.org/bugs/show_bug.cgi?id=31518 ).

You can use "utils/update_test_checks.py" to auto-generate exact CHECK lines for your test.


https://reviews.llvm.org/D27114