[PATCH] D28156: Add the 'googlemock' component of Google Test to LLVM's unittest libraries.

Wed Jan 4 06:15:57 PST 2017

chandlerc added a comment.

In https://reviews.llvm.org/D28156#632456, @chandlerc wrote:

> In https://reviews.llvm.org/D28156#632376, @silvas wrote:
>
> > You brought this up a couple years ago in the llvmdev thread "[LLVMdev] Any objections to my importing GoogleMock to go with GoogleTest in LLVM?" and was rejected (or at least stalled out) at the time. The context was also the same (wanting to unittest the new PM).
>
>
> Wow, I had completely forgotten about this. I think that makes this the third time I've tried...
>
> > I think that if the discussion of whether integrate gmock was important enough at the time to bring to llvmdev, that discussion probably still needs to be done on llvmdev.
>
> Sure, makes total sense. I'll keep the patches CC-ed to llvm-commits but once I have some examples to point to I'll rejuvenate the discussion on llvm-dev.

Thread started here: http://lists.llvm.org/pipermail/llvm-dev/2017-January/108672.html

I tried to give a more thorough discussion of what is proposed and links to example patches.

https://reviews.llvm.org/D28156